-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: changes to propagate traceid from client #32264
Conversation
Signed-off-by: Shreesha Srinath Madogaran <smadogaran@salesforce.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32264 +/- ##
==========================================
+ Coverage 81.05% 81.72% +0.67%
==========================================
Files 979 999 +20
Lines 140543 123903 -16640
==========================================
- Hits 113912 101256 -12656
+ Misses 22833 18763 -4070
- Partials 3798 3884 +86
|
/assign @longjiquan |
@madogar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
approved and wait for the modification of the description |
@xiaofan-luan had discussed about the issue on discord originally here: https://discord.com/channels/1160323594396635310/1216974209826164916 Have created a new issue on github and linked it to this PR now: |
@madogar E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: madogar, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#32321
Issue Description:
Tracing is an important means of identifying bottleneck points in a system and is crucial for debugging production issues. Milvus(or any DB) is generally the most downstream system for an user call -- a user call can originate from UI and pass through multiple components, in micro-services architecture, before reaching Milvus.
So, when an user experiences a glitch, one would debug the call trace via logs using a common trace id. As of now, Milvus generates a new trace id for every call and this request is to make sure client can pass the trace id which will be used for all the logs across the Milvus sub-components so that one can fetch logs for a user call across the components -- including Milvus.