Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: changes to propagate traceid from client #32264

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

madogar
Copy link
Contributor

@madogar madogar commented Apr 15, 2024

#32321

Issue Description:
Tracing is an important means of identifying bottleneck points in a system and is crucial for debugging production issues. Milvus(or any DB) is generally the most downstream system for an user call -- a user call can originate from UI and pass through multiple components, in micro-services architecture, before reaching Milvus.
So, when an user experiences a glitch, one would debug the call trace via logs using a common trace id. As of now, Milvus generates a new trace id for every call and this request is to make sure client can pass the trace id which will be used for all the logs across the Milvus sub-components so that one can fetch logs for a user call across the components -- including Milvus.

Signed-off-by: Shreesha Srinath Madogaran <smadogaran@salesforce.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.72%. Comparing base (fe2f34d) to head (96789fd).
Report is 157 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32264      +/-   ##
==========================================
+ Coverage   81.05%   81.72%   +0.67%     
==========================================
  Files         979      999      +20     
  Lines      140543   123903   -16640     
==========================================
- Hits       113912   101256   -12656     
+ Misses      22833    18763    -4070     
- Partials     3798     3884      +86     
Files Coverage Δ
pkg/util/logutil/grpc_interceptor.go 68.29% <ø> (-1.28%) ⬇️

... and 854 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/assign @longjiquan

@xiaofan-luan xiaofan-luan requested review from longjiquan and removed request for bigsheeper and godchen0212 April 15, 2024 20:33
@xiaofan-luan
Copy link
Contributor

@madogar
please add more comments on the issue

Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xiaofan-luan
Copy link
Contributor

approved and wait for the modification of the description

@madogar
Copy link
Contributor Author

madogar commented Apr 16, 2024

@xiaofan-luan had discussed about the issue on discord originally here: https://discord.com/channels/1160323594396635310/1216974209826164916

Have created a new issue on github and linked it to this PR now:
#32321

Copy link
Contributor

mergify bot commented Apr 16, 2024

@madogar E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@madogar
Copy link
Contributor Author

madogar commented Apr 16, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 16, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: madogar, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 919df4c into milvus-io:master Apr 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants