fix: Zero flushReq metric for all sealed segs #32404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@XuanYang-cn E2e jenkins job failed, comment |
XuanYang-cn
force-pushed
the
fix/flush-req-metrics
branch
from
fd729bb
to
7525557
Compare
|
@XuanYang-cn E2e jenkins job failed, comment |
XuanYang-cn
force-pushed
the
fix/flush-req-metrics
branch
from
7525557
to
e620aa5
Compare
|
rerun ut |
See also: milvus-io#32399 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn
force-pushed
the
fix/flush-req-metrics
branch
from
e620aa5
to
71c2d80
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32404 +/- ##
==========================================
- Coverage 81.80% 81.70% -0.10%
==========================================
Files 999 999
Lines 124240 124242 +2
==========================================
- Hits 101631 101511 -120
- Misses 18734 18841 +107
- Partials 3875 3890 +15
|
XuanYang-cn
added a commit
to XuanYang-cn/milvus
that referenced
this pull request
Apr 23, 2024
See also: milvus-io#32399 pr: milvus-io#32404 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #32399