Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add max insert request size and must use partition key configs #32433

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Apr 18, 2024

issue: #30577
/kind improvement

…onfigs

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/L Denotes a PR that changes 100-499 lines. labels Apr 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 18, 2024
Copy link
Contributor

mergify bot commented Apr 18, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Apr 18, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 18, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.76%. Comparing base (66fae53) to head (49571a0).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32433      +/-   ##
==========================================
- Coverage   81.76%   81.76%   -0.01%     
==========================================
  Files         999      999              
  Lines      124008   124045      +37     
==========================================
+ Hits       101400   101425      +25     
- Misses      18739    18747       +8     
- Partials     3869     3873       +4     
Files Coverage Δ
internal/proxy/impl.go 86.49% <100.00%> (+<0.01%) ⬆️
internal/proxy/task.go 88.00% <100.00%> (+0.03%) ⬆️
internal/proxy/task_insert.go 76.21% <100.00%> (+0.74%) ⬆️
internal/proxy/task_query.go 81.66% <100.00%> (+0.13%) ⬆️
internal/proxy/task_search.go 78.30% <100.00%> (+0.10%) ⬆️
pkg/util/merr/errors.go 86.95% <ø> (ø)
pkg/util/paramtable/component_param.go 98.42% <100.00%> (+<0.01%) ⬆️
pkg/util/paramtable/quota_param.go 73.94% <100.00%> (+0.15%) ⬆️
pkg/util/merr/utils.go 89.14% <60.00%> (-0.25%) ⬇️

... and 27 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 18, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8594b55 into milvus-io:master Apr 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants