Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return collection on recovering but not collection not loaded when target is not recovered #32447

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: return collection on recovering but not collection not loaded when target is not recovered #32447

merged 1 commit into from
Apr 25, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Apr 19, 2024

issue: #32398

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 19, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.77%. Comparing base (66fae53) to head (93087cc).
Report is 42 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #32447    +/-   ##
========================================
  Coverage   81.76%   81.77%            
========================================
  Files         999      999            
  Lines      124008   124117   +109     
========================================
+ Hits       101400   101493    +93     
- Misses      18739    18749    +10     
- Partials     3869     3875     +6
Files Coverage Δ
pkg/util/merr/errors.go 86.95% <ø> (ø)
pkg/util/merr/utils.go 89.25% <100.00%> (-0.14%) ⬇️
internal/querycoordv2/services.go 84.98% <50.00%> (+0.03%) ⬆️

... and 73 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Apr 22, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 23, 2024

/run-cpu-e2e

@chyezh chyezh force-pushed the fix_collection_not_loaded_error_code branch from 17d8f64 to 5c2127a Compare April 23, 2024 08:00
@chyezh chyezh changed the title fix: return lack of channel but not collection not loaded when target is not recovered fix: return collection on recovering but not collection not loaded when target is not recovered Apr 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 23, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 23, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 23, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Apr 23, 2024

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 23, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 24, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 24, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 24, 2024
@weiliu1031
Copy link
Contributor

/lgtm

congqixia
congqixia reviewed Apr 24, 2024
View reviewed changes
pkg/util/merr/errors.go Outdated Show resolved Hide resolved
@chyezh
fix: return collection on recovering but not collection not loaded wh…
93087cc 
…en target is not recovered

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fix_collection_not_loaded_error_code branch from 5c2127a to 93087cc Compare April 24, 2024 09:59
@sre-ci-robot sre-ci-robot removed the lgtm label Apr 24, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Apr 24, 2024
congqixia
congqixia approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b287fba into milvus-io:master Apr 25, 2024
15 checks passed
@chyezh chyezh deleted the fix_collection_not_loaded_error_code branch April 30, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@weiliu1031 weiliu1031 Awaiting requested review from weiliu1031

Assignees

@congqixia congqixia

@weiliu1031 weiliu1031

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chyezh @weiliu1031 @sre-ci-robot @congqixia