enhance: forbid delete with always true expression #32472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32472 +/- ##
==========================================
+ Coverage 81.74% 81.77% +0.02%
==========================================
Files 999 999
Lines 124080 124082 +2
==========================================
+ Hits 101426 101463 +37
+ Misses 18767 18745 -22
+ Partials 3887 3874 -13
|
|
@aoiasd please pick to branch 2.4 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aoiasd, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aoiasd
added a commit
to aoiasd/milvus
that referenced
this pull request
Apr 22, 2024
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
aoiasd
added a commit
to aoiasd/milvus
that referenced
this pull request
Apr 22, 2024
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
This was referenced Apr 22, 2024
xiaofan-luan
pushed a commit
that referenced
this pull request
Apr 23, 2024
aoiasd
added a commit
to aoiasd/milvus
that referenced
this pull request
Apr 24, 2024
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.