Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Make the dynamic field file optional during numpy import #32596

Merged
merged 6 commits into from
Apr 28, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Apr 25, 2024

  1. Make the dynamic field file optional during numpy import
  2. Add integration importing test with dynamic
  3. Disallow file of pk when autoID=true during numpy import

issue: #32542

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 25, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (967cfb3) to head (cfd446e).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32596      +/-   ##
==========================================
+ Coverage   81.72%   81.84%   +0.12%     
==========================================
  Files         998      989       -9     
  Lines      124044   124293     +249     
==========================================
+ Hits       101374   101729     +355     
+ Misses      18799    18708      -91     
+ Partials     3871     3856      -15     
Files Coverage Δ
internal/util/importutilv2/numpy/reader.go 73.07% <100.00%> (+5.95%) ⬆️
internal/util/importutilv2/numpy/util.go 48.21% <100.00%> (+9.89%) ⬆️
internal/util/importutilv2/reader.go 72.22% <100.00%> (ø)

... and 209 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Apr 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 25, 2024
@yhmo
Copy link
Contributor

yhmo commented Apr 26, 2024

/lgtm

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. and removed lgtm size/M Denotes a PR that changes 30-99 lines. labels Apr 28, 2024
@mergify mergify bot removed the ci-passed label Apr 28, 2024
@mergify mergify bot added the ci-passed label Apr 28, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1594122 into milvus-io:master Apr 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants