Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build milvus in rockylinux8 #32619

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: build milvus in rockylinux8 #32619

merged 1 commit into from
Apr 29, 2024

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Apr 25, 2024 •
edited

issue: #32299

  1. xz utils recovers
  2. forget to install ninja

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 25, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (c0555d4) to head (c09d5eb).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #32619   +/-   ##
=======================================
  Coverage   81.75%   81.76%           
=======================================
  Files         998      998           
  Lines      124172   124172           
=======================================
+ Hits       101519   101529   +10     
+ Misses      18792    18779   -13     
- Partials     3861     3864    +3

see 29 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 25, 2024
@samhuang-z
Copy link
Collaborator

/lgtm

@PowderLi
fix: build milvus in rockylinux8
c09d5eb 
1. xz utils recovers
2. forget to install ninja

Signed-off-by: PowderLi <min.li@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Apr 28, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Apr 28, 2024
@PowderLi
Copy link
Contributor Author

rerun ut

1 similar comment
@PowderLi
Copy link
Contributor Author

rerun ut

@czs007
Copy link
Contributor

czs007 commented Apr 29, 2024

/approve

@czs007
Copy link
Contributor

czs007 commented Apr 29, 2024

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6289f3a into milvus-io:master Apr 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

@samhuang-z samhuang-z

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PowderLi @samhuang-z @czs007 @sre-ci-robot