Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: sparse float vector to support brute force iterator and range search #32635

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #29419

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.81%. Comparing base (bed6363) to head (d321b2e).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32635      +/-   ##
==========================================
+ Coverage   81.74%   81.81%   +0.06%     
==========================================
  Files         998      989       -9     
  Lines      124035   124287     +252     
==========================================
+ Hits       101397   101683     +286     
+ Misses      18774    18749      -25     
+ Partials     3864     3855       -9     
Files Coverage Δ
internal/core/src/query/SearchBruteForce.cpp 81.53% <90.00%> (+1.53%) ⬆️

... and 207 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Apr 26, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

rerun ut

Copy link
Contributor

Hello zhengbuqian, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 26, 2024
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@czs007
Copy link
Contributor

czs007 commented Apr 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 858599d into milvus-io:master Apr 29, 2024
15 checks passed
@zhengbuqian zhengbuqian deleted the sparse-range-milvus branch April 29, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants