-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add WithBlock
option for etcd client creation
#32641
enhance: Add WithBlock
option for etcd client creation
#32641
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia ut workflow job failed, comment |
1 similar comment
@congqixia ut workflow job failed, comment |
@congqixia E2e jenkins job failed, comment |
Related to milvus-io#32598 Use `WithBlock` may fail fast when create etcd client to some invalid etcd endpoints and make it easier to check problem. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
ce0ad25
to
f54f57d
Compare
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32641 +/- ##
==========================================
- Coverage 81.82% 81.75% -0.07%
==========================================
Files 990 998 +8
Lines 124483 124042 -441
==========================================
- Hits 101852 101413 -439
- Misses 18767 18769 +2
+ Partials 3864 3860 -4
|
/lgtm |
Related to #32598
Use
WithBlock
may fail fast when create etcd client to some invalid etcd endpoints and make it easier to check problem.