Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add WithBlock option for etcd client creation #32641

Merged

Conversation

congqixia
Copy link
Contributor

Related to #32598

Use WithBlock may fail fast when create etcd client to some invalid etcd endpoints and make it easier to check problem.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Apr 26, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Related to milvus-io#32598

Use `WithBlock` may fail fast when create etcd client to some invalid etcd
endpoints and make it easier to check problem.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Copy link
Contributor

mergify bot commented Apr 26, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.75%. Comparing base (ccce1e9) to head (f54f57d).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32641      +/-   ##
==========================================
- Coverage   81.82%   81.75%   -0.07%     
==========================================
  Files         990      998       +8     
  Lines      124483   124042     -441     
==========================================
- Hits       101852   101413     -439     
- Misses      18767    18769       +2     
+ Partials     3864     3860       -4     
Files Coverage Δ
pkg/util/etcd/etcd_util.go 75.00% <42.85%> (-1.70%) ⬇️

... and 212 files with indirect coverage changes

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 28, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 967cfb3 into milvus-io:master Apr 28, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants