Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip the empty partition name in the rate limit interceptor #32647

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Apr 26, 2024

issue: #30577

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (ccce1e9) to head (c03ac88).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32647      +/-   ##
==========================================
- Coverage   81.82%   81.79%   -0.03%     
==========================================
  Files         990      998       +8     
  Lines      124483   124037     -446     
==========================================
- Hits       101852   101460     -392     
+ Misses      18767    18738      -29     
+ Partials     3864     3839      -25     
Files Coverage Δ
internal/proxy/rate_limit_interceptor.go 100.00% <100.00%> (ø)

... and 217 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 26, 2024
@bigsheeper
Copy link
Contributor

/lgtm

@czs007
Copy link
Contributor

czs007 commented Apr 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9a719ec into milvus-io:master Apr 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants