Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] add the config to control the way when fail to init plugin #32682

Closed
wants to merge 1 commit into from

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Apr 28, 2024

issue: #32679
pr: #32680

…ugin

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 28, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 28, 2024
@SimFG
Copy link
Contributor Author

SimFG commented Apr 29, 2024

rerun ut

1 similar comment
@SimFG
Copy link
Contributor Author

SimFG commented Apr 29, 2024

rerun ut

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (51e0855) to head (e74ee15).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32682      +/-   ##
==========================================
- Coverage   81.58%   81.57%   -0.01%     
==========================================
  Files         976      976              
  Lines      120147   120156       +9     
==========================================
+ Hits        98019    98021       +2     
  Misses      18396    18396              
- Partials     3732     3739       +7     
Files Coverage Δ
internal/proxy/hook_interceptor.go 81.25% <100.00%> (+3.83%) ⬆️
pkg/util/paramtable/component_param.go 98.54% <100.00%> (+<0.01%) ⬆️

... and 27 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 29, 2024
@sre-ci-robot sre-ci-robot deleted the branch milvus-io:2.4 April 30, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants