-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix GetShardLeaders return empty node list #32685
fix: fix GetShardLeaders return empty node list #32685
Conversation
@weiliu1031 E2e jenkins job failed, comment |
98d7691
to
ee3449a
Compare
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
ee3449a
to
0dd2b41
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32685 +/- ##
==========================================
- Coverage 81.75% 81.40% -0.36%
==========================================
Files 998 998
Lines 124172 124197 +25
==========================================
- Hits 101519 101102 -417
- Misses 18792 19212 +420
- Partials 3861 3883 +22
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #32449
to avoid GetShardLeaders return empty node list, this PR add node list check in both client side and server side.