Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix GetShardLeaders return empty node list #32685

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #32449

to avoid GetShardLeaders return empty node list, this PR add node list check in both client side and server side.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 28, 2024
Copy link
Contributor

mergify bot commented Apr 28, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 28, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Apr 29, 2024

/run-cpu-e2e

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@czs007 czs007 added this to the 2.4.1 milestone Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.40%. Comparing base (c0555d4) to head (0dd2b41).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32685      +/-   ##
==========================================
- Coverage   81.75%   81.40%   -0.36%     
==========================================
  Files         998      998              
  Lines      124172   124197      +25     
==========================================
- Hits       101519   101102     -417     
- Misses      18792    19212     +420     
- Partials     3861     3883      +22     
Files Coverage Δ
internal/proxy/lb_policy.go 100.00% <100.00%> (ø)
internal/querycoordv2/services.go 84.92% <0.00%> (-0.78%) ⬇️

... and 43 files with indirect coverage changes

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 29, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d900e68 into milvus-io:master Apr 29, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants