Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Upgrade knowhere to 2.3.1 #32699

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

liliu-z
Copy link
Member

@liliu-z liliu-z commented Apr 29, 2024

/kind improvement

Signed-off-by: Li Liu <li.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 29, 2024
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. area/compilation labels Apr 29, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Apr 29, 2024
Copy link
Contributor

mergify bot commented Apr 29, 2024

@liliu-z

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@liliu-z liliu-z changed the title upgrade knowhere to 2.3.1 enhance: Upgrade knowhere to 2.3.1 Apr 29, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Apr 29, 2024
Copy link
Contributor

mergify bot commented Apr 29, 2024

@liliu-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added this to the 2.4.1 milestone Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (29d3c57) to head (a2378bb).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32699      +/-   ##
==========================================
- Coverage   81.79%   81.76%   -0.03%     
==========================================
  Files         998      998              
  Lines      124188   124209      +21     
==========================================
- Hits       101576   101564      -12     
- Misses      18762    18781      +19     
- Partials     3850     3864      +14     

see 36 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 29, 2024
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a43baa0 into milvus-io:master Apr 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants