Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use default integration case timeout for TestBinlogImport #32701

Conversation

congqixia
Copy link
Contributor

See also #32700

See also milvus-io#32700

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/test sig/testing test/integration integration test labels Apr 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 29, 2024
Copy link
Contributor

mergify bot commented Apr 29, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 29, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 29, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (29d3c57) to head (2e16f69).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32701      +/-   ##
==========================================
- Coverage   81.79%   81.75%   -0.04%     
==========================================
  Files         998      998              
  Lines      124188   124207      +19     
==========================================
- Hits       101576   101549      -27     
- Misses      18762    18793      +31     
- Partials     3850     3865      +15     
Files Coverage Δ
tests/integration/minicluster_v2.go 72.51% <ø> (+0.54%) ⬆️

... and 39 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 29, 2024
@tedxu
Copy link
Collaborator

tedxu commented Apr 29, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit ecd8e52 into milvus-io:master Apr 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants