Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: disable reload partstats by config #32702

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

MrPresent-Han
Copy link
Contributor

No description provided.

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 29, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrPresent-Han, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added this to the 2.4.1 milestone Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.76%. Comparing base (967cfb3) to head (ae1f1d2).
Report is 23 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32702      +/-   ##
==========================================
+ Coverage   81.72%   81.76%   +0.03%     
==========================================
  Files         998      998              
  Lines      124044   124212     +168     
==========================================
+ Hits       101374   101559     +185     
+ Misses      18799    18788      -11     
+ Partials     3871     3865       -6     
Files Coverage Δ
internal/querynodev2/delegator/delegator.go 87.76% <0.00%> (-1.73%) ⬇️
internal/querynodev2/delegator/delegator_data.go 84.60% <0.00%> (+0.05%) ⬆️

... and 49 files with indirect coverage changes

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 29, 2024
@sre-ci-robot sre-ci-robot merged commit ac82cef into milvus-io:master Apr 29, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants