-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add request resource timeout for lazy load, refactor context usage in cache #32709
Conversation
@chyezh E2e jenkins job failed, comment |
1 similar comment
@chyezh E2e jenkins job failed, comment |
@chyezh ut workflow job failed, comment |
@chyezh E2e jenkins job failed, comment |
@chyezh ut workflow job failed, comment |
@chyezh ut workflow job failed, comment |
…ge in cache (milvus-io#32684) - Use new param to control request resource timeout for lazy load. - Remove the timeout parameter of `Do`, remove `DoWait`. use `context` to control the timeout. - Use `VersionedNotifier` to avoid notify event lost and broadcast, remove the redundant goroutine in cache. --------- Signed-off-by: chyezh <chyezh@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32709 +/- ##
==========================================
- Coverage 81.76% 81.71% -0.05%
==========================================
Files 998 1002 +4
Lines 124284 125438 +1154
==========================================
+ Hits 101621 102502 +881
- Misses 18795 19027 +232
- Partials 3868 3909 +41
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chyezh, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #32663
Use new param to control request resource timeout for lazy load.
Remove the timeout parameter of
Do
, removeDoWait
. usecontext
to control the timeout.Use
VersionedNotifier
to avoid notify event lost and broadcast, remove the redundant goroutine in cache.related dev pr: #32684