Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gc only do once #32722

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: gc only do once #32722

merged 1 commit into from
Apr 30, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Apr 30, 2024

issue: #29655

produced by pr: #31740

Signed-off-by: chyezh <chyezh@outlook.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 30, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (6289f3a) to head (aa9e55f).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #32722   +/-   ##
=======================================
  Coverage   81.72%   81.73%           
=======================================
  Files         998      998           
  Lines      124209   124292   +83     
=======================================
+ Hits       101513   101589   +76     
+ Misses      18822    18820    -2     
- Partials     3874     3883    +9     
Files Coverage Δ
internal/datacoord/garbage_collector.go 88.80% <100.00%> (ø)

... and 37 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 30, 2024
@sre-ci-robot sre-ci-robot merged commit 77f4f0c into milvus-io:master Apr 30, 2024
15 checks passed
@chyezh chyezh deleted the fix_bug_master branch April 30, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants