Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove deprecated api #32808

Merged

Conversation

longjiquan
Copy link
Contributor

issue: #32728

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (4de063a) to head (32c791c).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32808      +/-   ##
==========================================
+ Coverage   81.73%   81.82%   +0.08%     
==========================================
  Files        1002      993       -9     
  Lines      125438   125685     +247     
==========================================
+ Hits       102532   102836     +304     
+ Misses      18999    18953      -46     
+ Partials     3907     3896      -11     
Files Coverage Δ
internal/core/src/segcore/SegmentInterface.cpp 88.06% <100.00%> (-0.83%) ⬇️
internal/core/src/segcore/SegmentInterface.h 100.00% <ø> (ø)

... and 217 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 7, 2024
@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9837ad6 into milvus-io:master May 7, 2024
15 checks passed
@longjiquan longjiquan deleted the remove-deprecated-retrieve branch May 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants