Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix cannot specify partition name in binlog import (#32730) #32829

Conversation

bigsheeper
Copy link
Contributor

issue: #32807

pr: #32730

)

issue: milvus-io#32807

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/test sig/testing test/integration integration test labels May 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 7, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.77%. Comparing base (49b760f) to head (b31626a).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32829      +/-   ##
==========================================
- Coverage   81.79%   81.77%   -0.03%     
==========================================
  Files         999      999              
  Lines      124472   124481       +9     
==========================================
- Hits       101816   101793      -23     
- Misses      18781    18812      +31     
- Partials     3875     3876       +1     
Files Coverage Δ
internal/proxy/impl.go 86.36% <81.81%> (-0.11%) ⬇️

... and 28 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 8, 2024
@czs007
Copy link
Contributor

czs007 commented May 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 94bd2f0 into milvus-io:2.4 May 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants