Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Improve datacoord segment filtering with collection #32831

Merged
merged 2 commits into from
May 8, 2024
Merged

enhance: Improve datacoord segment filtering with collection #32831

merged 2 commits into from
May 8, 2024

Conversation

congqixia
Copy link
Contributor

See also #32165

This PR modify the SelectSegments interface to utilizing collection id information when selecting segment with provided collection

@congqixia
enhance: Improve datacoord segment filtering with collection
774e179 
See also milvus-io#32165

This PR modify the `SelectSegments` interface to utilizing collection id
information when selecting segment with provided collection

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby May 7, 2024 16:41
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. approved labels May 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 7, 2024
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited

Codecov Report

Attention: Patch coverage is 93.63636% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.81%. Comparing base (5038036) to head (bcaa699).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #32831    +/-   ##
========================================
  Coverage   81.81%   81.81%            
========================================
  Files        1005     1006     +1     
  Lines      126560   126723   +163     
========================================
+ Hits       103539   103681   +142     
- Misses      19085    19102    +17     
- Partials     3936     3940     +4
Files Coverage Δ
internal/datacoord/garbage_collector.go 89.27% <100.00%> (ø)
internal/datacoord/handler.go 79.76% <100.00%> (+0.62%) ⬆️
internal/datacoord/index_service.go 94.91% <100.00%> (ø)
internal/datacoord/meta.go 93.73% <100.00%> (+0.26%) ⬆️
internal/datacoord/segment_info.go 87.30% <94.87%> (+1.05%) ⬆️
internal/datacoord/segment_operator.go 92.00% <89.47%> (-8.00%) ⬇️
internal/datacoord/compaction.go 88.19% <0.00%> (+0.21%) ⬆️

... and 36 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 7, 2024
@congqixia
Remove debug log
bcaa699 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot removed the ci-passed label May 8, 2024
XuanYang-cn
XuanYang-cn approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 8, 2024
@sre-ci-robot sre-ci-robot merged commit cedb33c into milvus-io:master May 8, 2024
15 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request May 8, 2024
@congqixia
enhance: Improve datacoord segment filtering with collection (milvus-…
578bb41 
…io#32831)

See also milvus-io#32165

This PR modify the `SelectSegments` interface to utilizing collection id
information when selecting segment with provided collection

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this pull request May 8, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this pull request May 9, 2024
@congqixia
enhance: Improve datacoord segment filtering with collection (milvus-…
8a16718 
…io#32831)

See also milvus-io#32165

This PR modify the `SelectSegments` interface to utilizing collection id
information when selecting segment with provided collection

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request May 9, 2024
@congqixia
enhance: [2.4] Improve datacoord segment filtering with collection (#…
1f11bc4 
…32831) (#32874)

Cherry-pick from master
pr: #32831 
See also #32165

This PR modify the `SelectSegments` interface to utilizing collection id
information when selecting segment with provided collection

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@xiaofan-luan xiaofan-luan mentioned this pull request May 9, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanYang-cn XuanYang-cn XuanYang-cn approved these changes

@cydrain cydrain Awaiting requested review from cydrain

@sunby sunby Awaiting requested review from sunby

Assignees

@XuanYang-cn XuanYang-cn

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@congqixia @sre-ci-robot @XuanYang-cn