Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: use different value to get related data size according to segment type #33017

Merged
merged 1 commit into from May 14, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 13, 2024

issue: #30436

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 13, 2024
Copy link
Contributor

mergify bot commented May 13, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 13, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 13, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented May 13, 2024

/approve
/lgtm

Copy link
Contributor

mergify bot commented May 13, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented May 14, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 14, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented May 14, 2024

/run-cpu-e2e

1 similar comment
@SimFG
Copy link
Contributor Author

SimFG commented May 14, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 14, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

…gment type

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.08%. Comparing base (293f14a) to head (0e3d0f5).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33017      +/-   ##
==========================================
+ Coverage   82.06%   82.08%   +0.01%     
==========================================
  Files        1007     1005       -2     
  Lines      127699   127649      -50     
==========================================
- Hits       104793   104776      -17     
+ Misses      18931    18887      -44     
- Partials     3975     3986      +11     
Files Coverage Δ
internal/querycoordv2/utils/types.go 78.94% <ø> (-6.24%) ⬇️
internal/querynodev2/segments/retrieve.go 78.44% <100.00%> (ø)
internal/querynodev2/segments/utils.go 39.37% <100.00%> (+10.01%) ⬆️
internal/querynodev2/tasks/query_task.go 91.66% <100.00%> (ø)
internal/querynodev2/tasks/search_task.go 82.86% <70.00%> (-0.43%) ⬇️

... and 52 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 14, 2024
@jaime0815 jaime0815 added this to the 2.4.2 milestone May 14, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 1d48d0a into milvus-io:master May 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants