Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: etcd txn exceeds limit due to too many fields #33040

Merged
merged 3 commits into from
May 14, 2024

Conversation

longjiquan
Copy link
Contributor

fix: #33038

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 14, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@smellthemoon
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented May 14, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed lgtm size/XS Denotes a PR that changes 0-9 lines. labels May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.09%. Comparing base (a984e46) to head (eef7537).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33040      +/-   ##
==========================================
+ Coverage   82.04%   82.09%   +0.04%     
==========================================
  Files        1005     1005              
  Lines      127642   127653      +11     
==========================================
+ Hits       104729   104797      +68     
+ Misses      18932    18886      -46     
+ Partials     3981     3970      -11     
Files Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 89.40% <100.00%> (+0.04%) ⬆️
internal/metastore/kv/rootcoord/suffix_snapshot.go 82.31% <50.00%> (-0.51%) ⬇️

... and 32 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented May 14, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [czs007,xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label May 14, 2024
@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 14, 2024
@sre-ci-robot sre-ci-robot merged commit 3d85e6e into milvus-io:master May 14, 2024
14 of 15 checks passed
@longjiquan longjiquan deleted the fix-etcd-txn branch May 14, 2024 09:05
longjiquan added a commit to longjiquan/milvus that referenced this pull request May 14, 2024
fix: milvus-io#33038

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request May 15, 2024
fix: #33038
pr: #33040 

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: etcd txn may exceed limit when drop a collection with too many fields
5 participants