Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Break the dead loop of downloading binlog during compaction #33246

Merged
merged 3 commits into from
May 22, 2024
Merged

fix: Break the dead loop of downloading binlog during compaction #33246

merged 3 commits into from
May 22, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #33245

@xiaocai2333
Retry a certain times instead of waiting until it times out
226e61a 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 22, 2024
@mergify mergify bot added the dco-passed DCO check passed. label May 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels May 22, 2024
@czs007
Copy link
Contributor

czs007 commented May 22, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added this to the 2.3.16 milestone May 22, 2024
@xiaocai2333 xiaocai2333 changed the title fix: Retry a certain times instead of waiting until it times out fix: Break the deap loop of downloading binlog during compaction May 22, 2024
@xiaocai2333 xiaocai2333 changed the title fix: Break the deap loop of downloading binlog during compaction fix: Break the dead loop of downloading binlog during compaction May 22, 2024
@xiaocai2333
fix ut
fbff391 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed lgtm size/S Denotes a PR that changes 10-29 lines. labels May 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor

LGTM

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@xiaocai2333
fix checker
4f8e149 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented May 22, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (0ae4c8a) to head (4f8e149).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33246      +/-   ##
==========================================
+ Coverage   83.09%   83.10%   +0.01%     
==========================================
  Files         850      850              
  Lines      106717   106714       -3     
==========================================
+ Hits        88676    88687      +11     
+ Misses      14734    14722      -12     
+ Partials     3307     3305       -2
Files Coverage Δ
internal/datanode/binlog_io.go 90.36% <100.00%> (-0.18%) ⬇️

... and 14 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 22, 2024
@czs007
Copy link
Contributor

czs007 commented May 22, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 653af71 into milvus-io:2.3 May 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
2.3.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xiaocai2333 @czs007 @sre-ci-robot @XuanYang-cn