Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add index names tests for mulitple vectors support #33250

Merged
merged 2 commits into from
May 23, 2024
Merged

test: Add index names tests for mulitple vectors support #33250

merged 2 commits into from
May 23, 2024

Conversation

yanliang567
Copy link
Contributor

Related issue: #32653

  1. Update index name tests
  2. remove some time.sleep

@yanliang567
Add index names tests for mulitple vectors support
6c0f7c0 
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved area/test sig/testing size/XL Denotes a PR that changes 500-999 lines. labels May 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/test labels May 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Use a var to avoid index change
70b0b8d 
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@mergify mergify bot added the ci-passed label May 23, 2024
@binbinlv
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 00cd88e into milvus-io:master May 23, 2024
4 checks passed
@yanliang567 yanliang567 mentioned this pull request May 23, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request May 23, 2024
@yanliang567
test: [cherry pick] Add index name tests for multiple vectors (#33315)
8c9afd5 
Related issue: #32653
Related pr: #33250

---------

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThreadDao ThreadDao Awaiting requested review from ThreadDao

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@binbinlv binbinlv

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/test lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanliang567 @sre-ci-robot @binbinlv