enhance: optimize datanode cpu usage under large collection number #33267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
@xiaofan-luan ut workflow job failed, comment |
xiaofan-luan
force-pushed
the
OptimizeDatanodeCpu
branch
from
105c5f5
to
03b9200
Compare
|
@xiaofan-luan ut workflow job failed, comment |
xiaofan-luan
force-pushed
the
OptimizeDatanodeCpu
branch
from
03b9200
to
bbc0829
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33267 +/- ##
==========================================
- Coverage 82.20% 82.04% -0.17%
==========================================
Files 1009 1012 +3
Lines 128855 128858 +3
==========================================
- Hits 105927 105718 -209
- Misses 18944 19159 +215
+ Partials 3984 3981 -3
|
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
xiaofan-luan
force-pushed
the
OptimizeDatanodeCpu
branch
from
bbc0829
to
a8fe9a9
Compare
yiwangdr
reviewed
May 24, 2024
| func (gc *GroupChecker) Check(name string) { | ||
| gc.lastest.Insert(name, time.Now()) | ||
| func (gc *CheckerManager) Register(name string, checker *Checker) { | ||
| gc.checkers.Insert(name, checker) |
There was a problem hiding this comment.
It looks like we always create a new one. Should we check if name already exists?
|
/lgtm |
bigsheeper
pushed a commit
to bigsheeper/milvus
that referenced
this pull request
Jul 3, 2024
…ilvus-io#33267) Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
jaime0815
added a commit
to jaime0815/milvus
that referenced
this pull request
Jul 3, 2024
…ilvus-io#33267) fix milvus-io#33266 try to improve cpu usage by refactoring the ttchecker logic and caching string Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com> (cherry picked from commit 36cbce4) Co-authored-by:: jaime <yun.zhang@zilliz.com>
jaime0815
added a commit
to jaime0815/milvus
that referenced
this pull request
Jul 3, 2024
…ilvus-io#33267) fix milvus-io#33266 try to improve cpu usage by refactoring the ttchecker logic and caching string Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com> (cherry picked from commit 36cbce4) Co-authored-by:: jaime <yun.zhang@zilliz.com>
jaime0815
added a commit
to jaime0815/milvus
that referenced
this pull request
Jul 3, 2024
…ilvus-io#33267) fix milvus-io#33266 try to improve cpu usage by refactoring the ttchecker logic and caching string Co-authored-by: xiaofanluan <xiaofan.luan@zilliz.com> (cherry picked from commit 36cbce4) Signed-off-by: jaime <yun.zhang@zilliz.com>
jaime0815
added a commit
to jaime0815/milvus
that referenced
this pull request
Jul 3, 2024
…ilvus-io#33267) fix milvus-io#33266 try to improve cpu usage by refactoring the ttchecker logic and caching string Co-authored-by: yiwangdr <yiwangdr@gmail.com> (cherry picked from commit 36cbce4) Signed-off-by: jaime <yun.zhang@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 4, 2024
…date logic of ttchecker (#34383) This PR cherry-picks the following commits: - Try to improve cpu usage by refactoring the ttchecker logic and caching string. #33267 - Correct the update logic of timerecorder in the flowgraph to avoid false failure: "some node(s) haven't received input". #34339 issue: #33266, #34337 pr: #33267, #34339 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com> Co-authored-by: Xiaofan <83447078+xiaofan-luan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #33266
try to improve cpu usage by refactoring the ttchecker logic and caching string