Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: new messsage interface for log service #33286

Merged
merged 2 commits into from
Jun 11, 2024
Merged

enhance: new messsage interface for log service #33286

merged 2 commits into from
Jun 11, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented May 22, 2024

issue: #33285

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label May 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented May 23, 2024

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented May 23, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.76923% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.26%. Comparing base (cfea3f4) to head (007d061).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33286      +/-   ##
==========================================
- Coverage   81.75%   81.26%   -0.49%     
==========================================
  Files        1019     1036      +17     
  Lines      130732   132273    +1541     
==========================================
+ Hits       106876   107491     +615     
- Misses      19834    20727     +893     
- Partials     4022     4055      +33
Files Coverage Δ
internal/util/logserviceutil/message/builder.go 100.00% <100.00%> (ø)
...nal/util/logserviceutil/message/message_handler.go 100.00% <100.00%> (ø)
internal/util/logserviceutil/message/message_id.go 100.00% <100.00%> (ø)
internal/util/logserviceutil/message/version.go 100.00% <100.00%> (ø)
...ternal/util/logserviceutil/message/message_type.go 77.77% <77.77%> (ø)
internal/util/logserviceutil/message/properties.go 86.66% <86.66%> (ø)
...ternal/util/logserviceutil/message/message_impl.go 82.60% <82.60%> (ø)

... and 44 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented May 23, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 23, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented May 23, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 23, 2024
@bigsheeper
Copy link
Contributor

Just don't forget to remove all invocations to panic in the future.

@bigsheeper
Copy link
Contributor

/lgtm

@mergify mergify bot removed the ci-passed label Jun 3, 2024
@chyezh chyezh force-pushed the feat_log_service_message branch 2 times, most recently from a384eb8 to 2912c60 Compare June 3, 2024 07:39
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 3, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Jun 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 5, 2024

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@chyezh chyezh changed the title enhance: new messsage interfacefor log service enhance: new messsage interface for log service Jun 5, 2024
@mergify mergify bot added ci-passed dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. ci-passed labels Jun 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 6, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 6, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
enhance: new messsage interface for log service
f8fa1cc 
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh
enhance: add method for message package
007d061 
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh
Copy link
Contributor Author

chyezh commented Jun 7, 2024

rerun ut

@mergify mergify bot added the ci-passed label Jun 7, 2024
@bigsheeper
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2b7ee19 into milvus-io:master Jun 11, 2024
15 checks passed
@chyezh chyezh deleted the feat_log_service_message branch June 11, 2024 02:48
@chyezh chyezh mentioned this pull request Jun 22, 2024
Open
40 tasks
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@chyezh @yellow-shine
enhance: new messsage interface for log service (milvus-io#33286)
9026069 
issue: milvus-io#33285

---------

Signed-off-by: chyezh <chyezh@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper bigsheeper left review comments

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@bigsheeper bigsheeper

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chyezh @bigsheeper @congqixia @sre-ci-robot