Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix printing type of request #33289

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: Fix printing type of request #33289

merged 1 commit into from
May 23, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #31705

@bigsheeper
fix: Fix printing type of request
c1830dc 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 22, 2024
@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (33144a4) to head (c1830dc).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33289   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files        1009     1009           
  Lines      128856   128855    -1     
=======================================
+ Hits       105876   105878    +2     
+ Misses      18986    18982    -4     
- Partials     3994     3995    +1
Files Coverage Δ
internal/proxy/rate_limit_interceptor.go 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 22, 2024
@SimFG
Copy link
Contributor

SimFG commented May 23, 2024

/lgtm

@czs007
Copy link
Contributor

czs007 commented May 23, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 155cb40 into milvus-io:master May 23, 2024
15 checks passed
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request May 23, 2024
@bigsheeper
fix: Fix printing type of request (milvus-io#33289)
4014f70 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper bigsheeper mentioned this pull request May 23, 2024
Merged
czs007 pushed a commit that referenced this pull request May 23, 2024
@bigsheeper
fix: Fix printing type of request (#33289) (#33319)
62663ac 
issue: #31705

pr: #33289

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@SimFG SimFG

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bigsheeper @SimFG @czs007 @sre-ci-robot