Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: the proxy metric in the query request #33307

Merged
merged 1 commit into from
May 24, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 23, 2024

/kind improvement
issue: #33306

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 23, 2024
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 23, 2024
Copy link
Contributor

mergify bot commented May 23, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 23, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 23, 2024
@SimFG SimFG changed the title fix: the panic when db isn't existed in the rate limit interceptor enhance: the proxy metric in the query request May 23, 2024
@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.09%. Comparing base (32d3e22) to head (a56eaa4).
Report is 17 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33307      +/-   ##
==========================================
+ Coverage   82.07%   82.09%   +0.02%     
==========================================
  Files        1003     1012       +9     
  Lines      128993   128852     -141     
==========================================
- Hits       105869   105781      -88     
+ Misses      19138    19094      -44     
+ Partials     3986     3977       -9     
Files Coverage Δ
internal/proxy/impl.go 86.24% <100.00%> (-0.16%) ⬇️
internal/proxy/util.go 89.83% <100.00%> (-0.12%) ⬇️

... and 243 files with indirect coverage changes

Copy link
Contributor

mergify bot commented May 23, 2024

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 23, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: SimFG <bang.fu@zilliz.com>
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2964f60 into milvus-io:master May 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants