Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use seperate warmup pool and disable warmup by default (#33348) #33349

Merged
merged 7 commits into from
May 28, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented May 24, 2024

  1. use a small warmup pool to reduce the impact of warmup
  2. change the warmup pool to nonblocking mode
  3. disable warmup by default
  4. remove the maximum size limit of 16 for the load pool

issue: #32772

pr: #33348

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Co-authored-by: xiaofanluan <xiaofan.luan@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 24, 2024
Copy link
Contributor

mergify bot commented May 24, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.15%. Comparing base (e8c9bdf) to head (986a581).
Report is 18 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33349      +/-   ##
==========================================
+ Coverage   82.13%   82.15%   +0.01%     
==========================================
  Files        1006     1006              
  Lines      128162   128261      +99     
==========================================
+ Hits       105270   105367      +97     
+ Misses      18927    18926       -1     
- Partials     3965     3968       +3     
Files Coverage Δ
internal/querynodev2/segments/pool.go 100.00% <100.00%> (+2.73%) ⬆️
pkg/util/paramtable/component_param.go 98.48% <100.00%> (ø)
internal/querynodev2/segments/segment.go 66.59% <0.00%> (-0.55%) ⬇️

... and 39 files with indirect coverage changes

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify mergify bot added the ci-passed label May 24, 2024
@bigsheeper bigsheeper modified the milestone: 2.4.3 May 28, 2024
@xiaocai2333 xiaocai2333 added this to the 2.4.3 milestone May 28, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify mergify bot removed the ci-passed label May 28, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented May 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label May 28, 2024
@sre-ci-robot sre-ci-robot merged commit 7384bfe into milvus-io:2.4 May 28, 2024
15 checks passed
@bigsheeper
Copy link
Contributor Author

pr: #33433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants