Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add e2e test cases for GoSDK #33378

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ThreadDao
Copy link
Contributor

@ThreadDao ThreadDao commented May 24, 2024

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file area/test sig/testing labels May 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users do-not-merge/missing-related-issue labels May 24, 2024
Copy link
Contributor

mergify bot commented May 24, 2024

@ThreadDao Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@kenikadawan0129
Copy link

/approve

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (2453181) to head (80f7e4d).
Report is 37 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33378   +/-   ##
=======================================
  Coverage   82.15%   82.16%           
=======================================
  Files        1012     1012           
  Lines      129140   129140           
=======================================
+ Hits       106091   106103   +12     
+ Misses      19075    19048   -27     
- Partials     3974     3989   +15     

see 34 files with indirect coverage changes

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Copy link
Contributor

mergify bot commented May 28, 2024

@ThreadDao E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@ThreadDao
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 28, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, kenikadawan0129, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ac5e098 into milvus-io:master Jun 4, 2024
15 checks passed
@ThreadDao ThreadDao deleted the go-client-v2-test branch June 11, 2024 06:39
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
- Add e2e test cases for Go `milvusclient`
- Fix client SparseEmbedding to vector
issue: milvus-io#33419

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants