Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: [skip-e2e] add comments for task queue #33388

Merged
merged 1 commit into from
May 27, 2024

Conversation

ArenaSu
Copy link
Contributor

@ArenaSu ArenaSu commented May 27, 2024

Add comments for task queue in internal/proxy/task_scheduler.go.

Signed-off-by: ArenaSu <704427617@qq.com>
@sre-ci-robot
Copy link
Contributor

Welcome @ArenaSu! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/doc labels May 27, 2024
@ArenaSu
Copy link
Contributor Author

ArenaSu commented May 27, 2024

/assign @czs007

@czs007
Copy link
Contributor

czs007 commented May 27, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArenaSu, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented May 27, 2024

@ArenaSu ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (58ee613) to head (5b6bd0a).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33388      +/-   ##
==========================================
- Coverage   82.18%   82.18%   -0.01%     
==========================================
  Files        1012     1012              
  Lines      128957   128957              
==========================================
- Hits       105985   105982       -3     
- Misses      19000    19002       +2     
- Partials     3972     3973       +1     
Files Coverage Δ
internal/proxy/task_scheduler.go 95.34% <ø> (ø)

... and 36 files with indirect coverage changes

@ArenaSu
Copy link
Contributor Author

ArenaSu commented May 27, 2024

rerun ut

Copy link
Contributor

Hello ArenaSu, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

@ArenaSu
Copy link
Contributor Author

ArenaSu commented May 27, 2024

@czs007 I can not find any useful messages for Code Checker failure.I think comments do not affect it.

@ArenaSu
Copy link
Contributor Author

ArenaSu commented May 27, 2024

@milvus-io/milvus-maintainers Hi, can you give me permission to rerun workflow?

@mergify mergify bot added the ci-passed label May 27, 2024
@sre-ci-robot sre-ci-robot merged commit a59ed65 into milvus-io:master May 27, 2024
15 checks passed
@ArenaSu ArenaSu deleted the comment-task-scheduler branch May 28, 2024 01:36
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Add comments for task queue in internal/proxy/task_scheduler.go.

Signed-off-by: ArenaSu <704427617@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/doc lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants