Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show empty collection when has granted the all privilege #33445

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: show empty collection when has granted the all privilege #33445

merged 1 commit into from
May 29, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 29, 2024

@SimFG
fix: show empty collection when has granted the all privilege
178137e 
Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 29, 2024
@SimFG
Copy link
Contributor Author

SimFG commented May 29, 2024

rerun ut

1 similar comment
@SimFG
Copy link
Contributor Author

SimFG commented May 29, 2024

rerun ut

@SimFG SimFG mentioned this pull request May 29, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (73c9b80) to head (178137e).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33445      +/-   ##
==========================================
- Coverage   82.16%   82.14%   -0.03%     
==========================================
  Files        1012     1012              
  Lines      129199   129263      +64     
==========================================
+ Hits       106153   106179      +26     
- Misses      19071    19093      +22     
- Partials     3975     3991      +16
Files Coverage Δ
internal/rootcoord/show_collection_task.go 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 29, 2024
@czs007
Copy link
Contributor

czs007 commented May 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request May 29, 2024
@SimFG
fix: [2.4] show empty collection when has granted the all privilege (#…
23b0731 
…33454)

- issue: #33382
- pr: #33445

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot merged commit 8f46a20 into milvus-io:master May 29, 2024
15 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@SimFG @yellow-shine
fix: show empty collection when has granted the all privilege (milvus…
62d61fb 
…-io#33445)

- issue: milvus-io#33382

Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimFG @czs007 @sre-ci-robot