enhance: adding virtual resource allocator #33508
Conversation
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
mergify
bot
added
dco-passed
|
@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
|
@tedxu ut workflow job failed, comment |
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
|
@tedxu ut workflow job failed, comment |
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33508 +/- ##
==========================================
- Coverage 82.06% 81.98% -0.09%
==========================================
Files 1012 1015 +3
Lines 128806 130177 +1371
==========================================
+ Hits 105702 106721 +1019
- Misses 19112 19469 +357
+ Partials 3992 3987 -5
|
|
/lgtm |
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
| type Allocator interface { | ||
| // Allocate allocates the resource, returns true if the resource is allocated. If allocation failed, returns the short resource. | ||
| // The short resource is a positive value, e.g., if there is additional 8 bytes in disk needed, returns (0, 0, 8). | ||
| Allocate(id string, r *Resource) (allocated bool, short *Resource) |
There was a problem hiding this comment.
better to make id's type as generic type
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tedxu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
See milvus-io#33559 --------- Signed-off-by: Ted Xu <ted.xu@zilliz.com>
See #33559