Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add WITH_DNNL build config for knowhere. #33628

Closed
wants to merge 7 commits into from

Conversation

mellonyou
Copy link

Have submit a PR to knowhere, which is using AMX to speed up Faiss Inner-Product. Add this build config so that AMX implementation can be opened in the milvus.
The default configuration in scripts/core_build.sh is OFF:
BUILD_WITH_DNNL="OFF"

Knowhere PR: zilliztech/knowhere#535

@sre-ci-robot
Copy link
Contributor

Welcome @mellonyou! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mellonyou
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/compilation labels Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@mellonyou Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. do-not-merge/invalid-pr-format labels Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@mellonyou

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@mellonyou mellonyou changed the title Add WITH_DNNL build config for knowhere. [feat]: Add WITH_DNNL build config for knowhere. Jun 5, 2024
@mellonyou mellonyou changed the title [feat]: Add WITH_DNNL build config for knowhere. feat: Add WITH_DNNL build config for knowhere. Jun 5, 2024
@mellonyou mellonyou changed the title feat: Add WITH_DNNL build config for knowhere. enhance: Add WITH_DNNL build config for knowhere. Jun 5, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jun 5, 2024
@mellonyou mellonyou closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation kind/enhancement Issues or changes related to enhancement needs-dco DCO is missing in this pull request. size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants