Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add WITH_DNNL build config for knowhere. #33630

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mellonyou
Copy link

Have submit a PR to knowhere, which is using AMX to speed up Faiss Inner-Product. Add this build config so that AMX implementation can be opened in the milvus.
The default configuration in scripts/core_build.sh is OFF:
BUILD_WITH_DNNL="OFF"

Knowhere PR: zilliztech/knowhere#535

Signed-off-by: Eric Zhang <fangzheng.zhang@intel.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mellonyou
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added area/compilation size/S Denotes a PR that changes 10-29 lines. labels Jun 5, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@mellonyou Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@mellonyou E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mellonyou
Copy link
Author

/run-cpu-e2e

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jun 20, 2024
Copy link
Contributor

mergify bot commented Jun 20, 2024

@mellonyou E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants