Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support sparse cardinal hnsw index #33656

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #29419

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 5, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@zhengbuqian Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 5, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Jun 6, 2024
issue: #29419
pr: #33656

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
Co-authored-by: Buqian Zheng <zhengbuqian@gmail.com>
…growing/temp sparse index

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 15.55556% with 38 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (cfea3f4) to head (93a88a7).
Report is 31 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33656      +/-   ##
==========================================
+ Coverage   81.75%   81.80%   +0.05%     
==========================================
  Files        1019     1011       -8     
  Lines      130732   130964     +232     
==========================================
+ Hits       106876   107136     +260     
+ Misses      19834    19810      -24     
+ Partials     4022     4018       -4     
Files Coverage Δ
internal/core/src/segcore/IndexConfigGenerator.cpp 100.00% <100.00%> (ø)
internal/core/src/segcore/FieldIndexing.cpp 67.33% <50.00%> (-1.14%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp 77.59% <50.00%> (+0.18%) ⬆️
internal/core/src/index/IndexFactory.cpp 67.05% <0.00%> (+0.01%) ⬆️
internal/core/src/storage/DiskFileManagerImpl.cpp 60.49% <0.00%> (-4.02%) ⬇️

... and 224 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jun 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 12, 2024
@sre-ci-robot sre-ci-robot merged commit 47b04ea into milvus-io:master Jun 12, 2024
14 of 15 checks passed
@zhengbuqian zhengbuqian deleted the submut-sparse-cardinal branch June 12, 2024 08:58
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue: milvus-io#29419

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants