Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [GOSDK] Pass outputFields param in search request #33710

Merged

Conversation

congqixia
Copy link
Contributor

See also #33627

See also milvus-io#33627

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Jun 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 7, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (6ce9df9) to head (3a2588e).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33710      +/-   ##
==========================================
- Coverage   81.31%   81.24%   -0.08%     
==========================================
  Files        1021     1029       +8     
  Lines      132408   132215     -193     
==========================================
- Hits       107672   107420     -252     
- Misses      20694    20751      +57     
- Partials     4042     4044       +2     

see 219 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 7, 2024
@sre-ci-robot sre-ci-robot merged commit 80a2cd1 into milvus-io:master Jun 7, 2024
15 checks passed
CocaineCong pushed a commit to CocaineCong/milvus that referenced this pull request Jun 11, 2024
See also milvus-io#33627

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: FanOne <294350394@qq.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
See also milvus-io#33627

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants