Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add rbac support on describe/alter database api #33803

Merged

Conversation

weiliu1031
Copy link
Contributor

issue: #32707

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 12, 2024
@weiliu1031
Copy link
Contributor Author

rerun ut

@SimFG
Copy link
Contributor

SimFG commented Jun 13, 2024

/lgtm

@weiliu1031
Copy link
Contributor Author

rerun ut

sre-ci-robot pushed a commit that referenced this pull request Jun 13, 2024
issue: #32707
pr: #33803

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 force-pushed the enable_rbac_on_alter_database branch from 306e50c to 390eb3f Compare June 13, 2024 09:50
@sre-ci-robot sre-ci-robot removed the lgtm label Jun 13, 2024
Copy link
Contributor

mergify bot commented Jun 13, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jun 13, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (9d4535c) to head (390eb3f).
Report is 29 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33803      +/-   ##
==========================================
- Coverage   80.91%   80.91%   -0.01%     
==========================================
  Files        1058     1058              
  Lines      135193   135252      +59     
==========================================
+ Hits       109397   109434      +37     
- Misses      21613    21634      +21     
- Partials     4183     4184       +1     
Files Coverage Δ
pkg/util/constant.go 93.33% <ø> (ø)

... and 31 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 14, 2024
@SimFG
Copy link
Contributor

SimFG commented Jun 14, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b72026c into milvus-io:master Jun 17, 2024
15 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants