Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add trace for bf cost in l0 compactor #33860

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

weiliu1031
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 14, 2024
Copy link
Contributor

mergify bot commented Jun 14, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (5fac2fa) to head (e076a7c).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33860      +/-   ##
==========================================
- Coverage   80.89%   80.89%   -0.01%     
==========================================
  Files        1063     1064       +1     
  Lines      136139   136247     +108     
==========================================
+ Hits       110136   110218      +82     
- Misses      21817    21829      +12     
- Partials     4186     4200      +14     
Files Coverage Δ
internal/datanode/compaction/l0_compactor.go 92.43% <100.00%> (+0.12%) ⬆️

... and 27 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented Jun 18, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 18, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 18, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
Copy link
Contributor Author

retun ut

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 31ef0a1 into milvus-io:master Jun 20, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 20, 2024
pr: #33860

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants