Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: autoindex for multi data type #33868

Merged

Conversation

chasingegg
Copy link
Contributor

@chasingegg chasingegg commented Jun 14, 2024

issue: #22837

contain #33625 #33867 #33911 which already merged to 2.4 branch

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 14, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 14, 2024
Copy link
Contributor

mergify bot commented Jun 14, 2024

@chasingegg Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 14, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jun 14, 2024
Copy link
Contributor

mergify bot commented Jun 14, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (e83ecd5) to head (aeeb1e7).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33868      +/-   ##
==========================================
- Coverage   80.94%   80.87%   -0.07%     
==========================================
  Files        1050     1058       +8     
  Lines      135805   135677     -128     
==========================================
- Hits       109930   109735     -195     
- Misses      21688    21748      +60     
- Partials     4187     4194       +7     
Files Coverage Δ
internal/querynodev2/optimizers/query_hook.go 86.36% <100.00%> (+0.31%) ⬆️
pkg/common/common.go 79.59% <ø> (ø)
...util/indexparamcheck/binary_vector_base_checker.go 100.00% <100.00%> (ø)
.../util/indexparamcheck/float_vector_base_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/hnsw_checker.go 100.00% <100.00%> (ø)
...ndexparamcheck/sparse_float_vector_base_checker.go 57.89% <100.00%> (+21.05%) ⬆️
pkg/util/indexparams/index_params.go 90.43% <100.00%> (+0.09%) ⬆️
pkg/util/indexparamcheck/base_checker.go 90.90% <0.00%> (ø)
pkg/util/paramtable/autoindex_param.go 91.59% <96.42%> (+1.59%) ⬆️
internal/proxy/task_index.go 79.66% <82.35%> (-0.31%) ⬇️

... and 226 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 14, 2024
@mergify mergify bot removed the ci-passed label Jun 14, 2024
sre-ci-robot pushed a commit that referenced this pull request Jun 14, 2024
issue: #22837 
pr: #33868

- opensource autoindex support
- metric type check for different data types
- autoindex data type for search param

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@mergify mergify bot added the ci-passed label Jun 14, 2024
@mergify mergify bot removed the ci-passed label Jun 17, 2024
Copy link
Contributor

mergify bot commented Jun 17, 2024

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Jun 17, 2024
issue: #22837 
pr: #33868 

Use primitive type instead of proto enum type for queryHook to recognize

Signed-off-by: chasingegg <chao.gao@zilliz.com>
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@mergify mergify bot added the ci-passed label Jun 18, 2024
@czs007
Copy link
Contributor

czs007 commented Jun 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a789c60 into milvus-io:master Jun 18, 2024
15 checks passed
@chasingegg chasingegg deleted the autoindex-multi-type-master branch June 18, 2024 13:40
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue: milvus-io#22837 

contain milvus-io#33625
milvus-io#33867
milvus-io#33911 which already merged to
2.4 branch

Signed-off-by: chasingegg <chao.gao@zilliz.com>
Co-authored-by: foxspy <xianliang.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants