Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add cases for go milvusclient query #33884

Merged
merged 2 commits into from
Jun 26, 2024
Merged

test: add cases for go milvusclient query #33884

merged 2 commits into from
Jun 26, 2024

Conversation

ThreadDao
Copy link
Contributor

issue: #33419

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/test sig/testing size/XXL Denotes a PR that changes 1000+ lines. labels Jun 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/test labels Jun 14, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (ac28402) to head (2afe2b8).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #33884       +/-   ##
===========================================
+ Coverage   69.80%   81.03%   +11.22%     
===========================================
  Files        1077     1077               
  Lines      137148   137152        +4     
===========================================
+ Hits        95731   111135    +15404     
+ Misses      37201    21809    -15392     
+ Partials     4216     4208        -8

see 267 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 14, 2024
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Jun 18, 2024
@mergify mergify bot removed the ci-passed label Jun 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 18, 2024

@ThreadDao E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024

@ThreadDao E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@ThreadDao ThreadDao changed the title test: add cases for go milvusclient query and add go Slice func for go client column test: add cases for go milvusclient query Jun 21, 2024
@mergify mergify bot added the ci-passed label Jun 21, 2024
@mergify mergify bot removed the ci-passed label Jun 21, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 24, 2024

@ThreadDao ut workflow job failed, comment rerun ut can trigger the job again.

@ThreadDao
test: add cases to test go milvusclient query
ff2aaa9 
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
@ThreadDao
test: fix error check and some cases
2afe2b8 
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
@mergify mergify bot added the ci-passed label Jun 25, 2024
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThreadDao, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a77e295 into milvus-io:master Jun 26, 2024
12 checks passed
@ThreadDao ThreadDao deleted the go-query branch June 27, 2024 02:35
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@ThreadDao @yellow-shine
test: add cases for go milvusclient query (milvus-io#33884)
285d8ef 
issue: milvus-io#33419

---------

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@yanliang567 yanliang567

Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/test lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThreadDao @yanliang567 @sre-ci-robot