Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Check the correct return error in MultiRemove (#33926) #33966

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #33926
See also #33925

See also milvus-io#33925

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Jun 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 19, 2024
Copy link
Contributor

mergify bot commented Jun 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jun 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.28%. Comparing base (60695bd) to head (f82d71e).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33966      +/-   ##
==========================================
+ Coverage   82.24%   82.28%   +0.03%     
==========================================
  Files        1015     1015              
  Lines      130620   129461    -1159     
==========================================
- Hits       107433   106528     -905     
+ Misses      19219    18939     -280     
- Partials     3968     3994      +26     
Files Coverage Δ
internal/kv/tikv/txn_tikv.go 83.56% <100.00%> (ø)

... and 150 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 20, 2024
@XuanYang-cn
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit c28b693 into milvus-io:2.4 Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants