Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: use segment id and type to register in MmapChunkManager and opt malloc in variableChunk #33993

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

cqy123456
Copy link
Contributor

issue: #32984

@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Jun 19, 2024
@cqy123456 cqy123456 changed the title enhance: use segment id and type to register in mmapchunkmanager enhance: use segment id and type to register in MmapChunkManager Jun 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 19, 2024
@cqy123456 cqy123456 changed the title enhance: use segment id and type to register in MmapChunkManager enhance: use segment id and type to register in MmapChunkManager and opt malloc in variableChunk Jun 19, 2024
Copy link
Contributor

mergify bot commented Jun 19, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 19, 2024

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (2a13569) to head (9a9cd90).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33993      +/-   ##
==========================================
- Coverage   81.01%   81.00%   -0.02%     
==========================================
  Files        1056     1056              
  Lines      136771   136796      +25     
==========================================
+ Hits       110803   110809       +6     
- Misses      21754    21769      +15     
- Partials     4214     4218       +4     
Files Coverage Δ
internal/core/src/mmap/ChunkData.h 82.27% <100.00%> (+4.85%) ⬆️
internal/core/src/mmap/ChunkVector.h 77.77% <100.00%> (+0.35%) ⬆️
internal/core/src/mmap/Column.h 81.93% <ø> (ø)
internal/core/src/segcore/ConcurrentVector.h 96.94% <ø> (ø)
internal/core/src/segcore/InsertRecord.h 91.11% <100.00%> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 84.05% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 76.21% <100.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 80.00% <ø> (ø)
internal/core/src/storage/ChunkCache.cpp 59.18% <ø> (ø)
internal/core/src/storage/ChunkCache.h 100.00% <ø> (ø)
... and 2 more

... and 29 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jun 20, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jun 20, 2024
@sre-ci-robot sre-ci-robot merged commit dc4437f into milvus-io:master Jun 20, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 25, 2024
issue: issue: #32984
related pr: #32633,
#33951,
#33993

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
…opt malloc in variableChunk (milvus-io#33993)

issue: milvus-io#32984

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants