fix: Prevent import from generating orphaned files #34070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
mergify
bot
added
dco-passed
…6-reduce-orphan
sre-ci-robot
added
size/S
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34070 +/- ##
==========================================
+ Coverage 80.81% 80.85% +0.03%
==========================================
Files 1080 1072 -8
Lines 137009 137226 +217
==========================================
+ Hits 110726 110953 +227
+ Misses 22069 22052 -17
- Partials 4214 4221 +7
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Jun 25, 2024
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Jul 2, 2024
When import failed, mark the import segment as dropped instead of drop it directly to prevent generating orphaned files. issue: milvus-io#34068 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
bigsheeper
added a commit
to bigsheeper/milvus
that referenced
this pull request
Jul 12, 2024
…ilvus-io#34071) When import failed, mark the import segment as dropped instead of drop it directly to prevent generating orphaned files. issue: milvus-io#34068 pr: milvus-io#34070 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
bigsheeper
added a commit
to bigsheeper/milvus
that referenced
this pull request
Jul 12, 2024
…ilvus-io#34071) When import failed, mark the import segment as dropped instead of drop it directly to prevent generating orphaned files. issue: milvus-io#34068 pr: milvus-io#34070 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When import failed, mark the import segment as dropped instead of drop it directly to prevent generating orphaned files.
issue: #34068