Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove the lock in the msgdispatch/target struct #34076

Closed
wants to merge 1 commit into from

enhance: remove the lock in the msgdispatch/target struct

e6d9067
Select commit
Loading
Failed to load commit list.
Closed

enhance: remove the lock in the msgdispatch/target struct #34076

enhance: remove the lock in the msgdispatch/target struct
e6d9067
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Jun 26, 2024 in 1s

4 rules match and 21 potential rules

Rule: Add needs-dco label when DCO check failed (label, comment)

  • -status-success=DCO
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

✅ Rule: Add dco-passed label when DCO check passed (label)

  • status-success=DCO
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for code changed-master (label)

  • status-success=Integration Test
  • status-success=UT for Go
  • status-success=UT for Cpp
  • status-success=cpu-e2e
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$
  • any of:
    • status-success=Build and test AMD64 Ubuntu 20.04
    • status-success=Build and test AMD64 Ubuntu 22.04

Rule: Test passed for tests changed (label)

  • -files~=^(?!tests\/python_client).+
  • status-success=cpu-e2e
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for docs changed only (label)

  • -files~=^(?!.*\.(md)).*$
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for non go or c++ code changed (label)

  • -files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • status-success=cpu-e2e
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for go unittest code changed-master (label)

  • status-success=UT for Go
  • any of:
    • -files~=^(?!internal\/.*_test\.go).*$
    • -files~=^(?!pkg\/.*_test\.go).*$
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$
  • any of:
    • status-success=Build and test AMD64 Ubuntu 20.04
    • status-success=Build and test AMD64 Ubuntu 22.04

Rule: Test passed for mergify changed (label)

  • -files~=^(?!\.github\/mergify\.yml).*$
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for title skip e2e (label)

  • -files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • title~=\[skip e2e\]
  • label=kind/enhancement
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Blocking PR if missing a related issue or doesn't have kind/enhancement label (label, comment)

  • all of:
    • -body~=\#[0-9]{1,6}(\s+|$)
    • -body~=https://github.com/milvus-io/milvus/issues/[0-9]{1,6}(\s+|$)
  • any of:
    • label=kind/bug
    • label=kind/feature
    • all of:
      • any of:
        • label=size/L
        • label=size/XL
        • label=size/XXL
      • label=kind/enhancement
  • -label=kind/doc
  • -label=kind/test
  • -title~=\[automated\]
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

✅ Rule: Dismiss block label if related issue be added into PR (label)

  • all of:
    • any of:
      • base=master
      • base=sql_beta
      • base~=^2(\.\d+){1,2}$
    • any of:
      • body~=\#[0-9]{1,6}(\s+|$)
      • body~=https://github.com/milvus-io/milvus/issues/[0-9]{1,6}(\s+|$)

Rule: Dismiss block label if automated create PR (label)

  • title~=\[automated\]
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for skip e2e-master (label)

  • status-success=Integration Test
  • status-success=UT for Go
  • title~=\[skip e2e\]
  • files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • status-success=UT for Cpp
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$
  • any of:
    • status-success=Build and test AMD64 Ubuntu 20.04
    • status-success=Build and test AMD64 Ubuntu 22.04

Rule: Assign the 'lgtm' and 'approved' labels following the successful testing of the 'Update Knowhere Commit' (label)

  • label=ci-passed
  • title~=Update Knowhere Commit
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

✅ Rule: Remove ci-passed label when status for code checker or ut is not success-master (label)

  • files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • label!=manual-pass
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$
  • any of:
    • status-success!=Integration Test
    • status-success!=UT for Go
    • check-failure=Build and test AMD64 Ubuntu 20.04
    • check-failure=Build and test AMD64 Ubuntu 22.04
    • status-success!=UT for Cpp

Rule: Remove ci-passed label when status for jenkins job is not success (label)

  • status-success!=cpu-e2e
  • -title~=\[skip e2e\]
  • files~=^(?!(.*_test\.go|.*\.md)).*$
  • label!=manual-pass
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Add comment when jenkins job failed (comment)

  • check-failure=cpu-e2e
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Add comment when code checker or ut failed -master (comment)

  • any of:
    • check-failure=Build and test AMD64 Ubuntu 20.04
  • any of:
    • base=master
    • base=sql_beta
    • base~=^2(\.\d+){1,2}$

Rule: Add 'do-not-merge/invalid-pr-format' label for invalid PR titles (label, comment)

  • any of:
    • -title~=^(feat:|enhance:|fix:|test:|doc:|auto:|\[automated\])
    • body=^$
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$

Rule: Remove 'do-not-merge/invalid-pr-format' label for valid PRs (label)

  • label=do-not-merge/invalid-pr-format
  • -body=^$
  • title~=^(feat:|enhance:|fix:|test:|doc:|auto:|\[automated\])
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$

Rule: Label bug fix PRs (label)

  • title~=^fix:
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$

Rule: Label feature PRs (label)

  • title~=^feat:
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$

✅ Rule: Label enhancement PRs (label)

  • title~=^enhance:
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$

Rule: Label test PRs (label)

  • title~=^test:
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$

Rule: Label doc PRs (label)

  • title~=^doc:
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$

💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!


7 not applicable rules

Rule: Test passed for code changed -2.. (label)

  • base~=^2(\.\d+){2}$
  • status-success=Integration Test
  • status-success=UT for Go
  • status-success=UT for Cpp
  • status-success=cpu-e2e
  • any of:
    • status-success=Build and test AMD64 Ubuntu 20.04
    • status-success=Build and test AMD64 Ubuntu 22.04

Rule: Test passed for go unittest code changed -2.2.* (label)

  • -files~=^(?!internal\/.*_test\.go).*$
  • base~=^2\.2\.\d+$
  • any of:
    • status-success=Build and test AMD64 Ubuntu 20.04
    • status-success=Build and test AMD64 Ubuntu 22.04

Rule: Blocking PR if missing a related master PR or doesn't have kind/branch-feature label (label, comment)

  • base~=^2(\.\d+){1,2}$
  • -label=kind/branch-feature
  • -title~=\[automated\]
  • all of:
    • -body~=https://github.com/milvus-io/milvus/pull/[0-9]{1,6}(\s+|$)
    • -body~=pr\:\ \#[0-9]{1,6}(\s+|$)

Rule: Dismiss block label if related pr be added into PR (label)

  • base~=^2(\.\d+){1,2}$
  • any of:
    • body~=https://github.com/milvus-io/milvus/pull/[0-9]{1,6}(\s+|$)
    • body~=pr\:\ \#[0-9]{1,6}(\s+|$)
    • label=kind/branch-feature

Rule: Test passed for skip e2e - 2.2.* (label)

  • base~=^2\.2\.\d+$
  • status-success=Integration Test
  • status-success=UT for Go
  • title~=\[skip e2e\]
  • files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • status-success=UT for Cpp
  • any of:
    • status-success=Build and test AMD64 Ubuntu 20.04
    • status-success=Build and test AMD64 Ubuntu 22.04

Rule: Remove ci-passed label when status for code checker or ut is not success-2.2.* (label)

  • base~=^2\.2\.\d+$
  • files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • label!=manual-pass
  • any of:
    • status-success!=Integration Test
    • status-success!=UT for Go
    • check-failure=Build and test AMD64 Ubuntu 20.04
    • check-failure=Build and test AMD64 Ubuntu 22.04
    • status-success!=UT for Cpp

Rule: Add comment when code checker or ut failed -2.2.* (comment)

  • base~=^2\.2\.\d+$
  • any of:
    • check-failure=Build and test AMD64 Ubuntu 20.04
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com