Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove CheckVecIndexWithDataTypeExist function in pkg and remove some cgo call #34102

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Jun 24, 2024

issue: #22837
related pr: #34104

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 24, 2024
Copy link
Contributor

mergify bot commented Jun 24, 2024

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

@cqy123456
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.63%. Comparing base (ac28402) to head (c328108).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #34102       +/-   ##
===========================================
+ Coverage   69.80%   84.63%   +14.83%     
===========================================
  Files        1077      810      -267     
  Lines      137148   113139    -24009     
===========================================
+ Hits        95731    95756       +25     
+ Misses      37201    13167    -24034     
  Partials     4216     4216               
Files Coverage Δ
internal/proxy/cgo_util.go 100.00% <100.00%> (ø)
internal/proxy/task_index.go 79.79% <100.00%> (ø)
pkg/util/indexparamcheck/utils.go 100.00% <ø> (ø)

... and 302 files with indirect coverage changes

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@mergify mergify bot added the ci-passed label Jun 25, 2024
@jaime0815
Copy link
Contributor

/lgtm

@jaime0815
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456, jaime0815
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815 jaime0815 merged commit 51ebe95 into milvus-io:master Jun 26, 2024
11 of 12 checks passed
jaime0815 pushed a commit that referenced this pull request Jun 26, 2024
…in pkg (#34104)

issue: #22837
related pr: #34102

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
…move some cgo call (milvus-io#34102)

issue: milvus-io#22837
related pr: milvus-io#34104

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants