Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate gin logs failed cause access logs panic #34142

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jun 25, 2024

relate: #34141

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.91%. Comparing base (e5d691d) to head (71d66ed).
Report is 50 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34142      +/-   ##
==========================================
- Coverage   80.44%   70.91%   -9.54%     
==========================================
  Files        1086     1084       -2     
  Lines      137670   137517     -153     
==========================================
- Hits       110744    97514   -13230     
- Misses      22756    35868   +13112     
+ Partials     4170     4135      -35     
Files Coverage Δ
internal/proxy/accesslog/info/restful_info.go 73.62% <100.00%> (-1.66%) ⬇️

... and 248 files with indirect coverage changes

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 233b848 into milvus-io:master Jul 5, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants