Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: update new mmap config parmeters version #34143

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Jun 25, 2024

issue: #32984
related pr: #34145

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (ac28402) to head (e4613b5).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #34143       +/-   ##
===========================================
+ Coverage   69.80%   80.72%   +10.92%     
===========================================
  Files        1077     1077               
  Lines      137148   137152        +4     
===========================================
+ Hits        95731   110717    +14986     
+ Misses      37201    22218    -14983     
- Partials     4216     4217        +1     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.48% <100.00%> (ø)

... and 262 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jun 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jun 25, 2024
@sre-ci-robot sre-ci-robot merged commit 381d437 into milvus-io:master Jun 25, 2024
12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 25, 2024
issue: #32984
related pr: #34143

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue: milvus-io#32984
related pr: milvus-io#34145

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants