-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: implement wal managerment on streaming node #34153
enhance: implement wal managerment on streaming node #34153
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
04540a1
to
993b7ca
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34153 +/- ##
==========================================
+ Coverage 80.92% 84.30% +3.37%
==========================================
Files 1113 850 -263
Lines 138345 114624 -23721
==========================================
- Hits 111960 96629 -15331
+ Misses 22145 13749 -8396
- Partials 4240 4246 +6
|
993b7ca
to
a629dd4
Compare
Signed-off-by: chyezh <chyezh@outlook.com>
a629dd4
to
9c38b5c
Compare
Signed-off-by: chyezh <chyezh@outlook.com>
9c38b5c
to
89e22f3
Compare
Signed-off-by: chyezh <chyezh@outlook.com>
83abef5
to
fcfdc6b
Compare
|
||
// backgroundTask is the background task for wal manager. | ||
// wal open/close operation is executed in background task with single goroutine. | ||
func (w *walLifetime) backgroundTask() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest using one background task to process life time of all WALs that is goruntines effective
// because new Current state after these operation must be same or greater than expected state. | ||
|
||
// term must be increasing or available -> unavailable, close current term wal is always applied. | ||
term := currentState.Term() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following code snippet can move into renew function
fix unresolved issues in the next PR. |
/lgtm |
issue: #33285