Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix error ignore in compactor #34169

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: fix error ignore in compactor #34169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/datanode/compaction/clustering_compactor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,7 @@

if err := t.binlogIO.Upload(ctx, kvs); err != nil {
log.Warn("compact wrong, failed to upload kvs", zap.Error(err))
return err

Check warning on line 774 in internal/datanode/compaction/clustering_compactor.go

View check run for this annotation

Codecov / codecov/patch

internal/datanode/compaction/clustering_compactor.go#L774 

Added line #L774 was not covered by tests
}

for fID, path := range partialBinlogs {
Expand Down
3 changes: 3 additions & 0 deletions internal/datanode/compaction/mix_compactor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@
allValues, err := t.binlogIO.Download(ctx, paths)
if err != nil {
log.Warn("compact wrong, fail to download insertLogs", zap.Error(err))
return nil, err

Check warning on line 154 in internal/datanode/compaction/mix_compactor.go

View check run for this annotation

Codecov / codecov/patch

internal/datanode/compaction/mix_compactor.go#L154 

Added line #L154 was not covered by tests
}
downloadTimeCost += time.Since(downloadStart)

Expand Down Expand Up @@ -205,6 +206,7 @@
uploadStart := time.Now()
if err := t.binlogIO.Upload(ctx, kvs); err != nil {
log.Warn("compact wrong, failed to upload kvs", zap.Error(err))
return nil, err

Check warning on line 209 in internal/datanode/compaction/mix_compactor.go

View check run for this annotation

Codecov / codecov/patch

internal/datanode/compaction/mix_compactor.go#L209 

Added line #L209 was not covered by tests
}
uploadTimeCost += time.Since(uploadStart)
mergeFieldBinlogs(allBinlogs, partialBinlogs)
Expand All @@ -226,6 +228,7 @@
uploadStart := time.Now()
if err := t.binlogIO.Upload(ctx, kvs); err != nil {
log.Warn("compact wrong, failed to upload kvs", zap.Error(err))
return nil, err

Check warning on line 231 in internal/datanode/compaction/mix_compactor.go

View check run for this annotation

Codecov / codecov/patch

internal/datanode/compaction/mix_compactor.go#L231 

Added line #L231 was not covered by tests
}
uploadTimeCost += time.Since(uploadStart)

Expand Down
Loading